Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stagger_output needs Pry::Pager to be loaded in the parent scope #39

Merged
merged 1 commit into from
Feb 6, 2013
Merged

stagger_output needs Pry::Pager to be loaded in the parent scope #39

merged 1 commit into from
Feb 6, 2013
+1 −0

Conversation

pcmantz
Copy link
Contributor

@pcmantz pcmantz commented Feb 6, 2013

in at least Pry 0.9.11.4, Pry::Helpers::BaseHelpers#receive_raw assumes that you have Pry::Pager loaded in the including context and does not require it explicitly, so you get this:

[pry-remote-em] unable to load keyboard depenencies (termios); interactive shell commands disabled
[pry-remote-em] client connected to pryem://127.0.0.1:6463/
[pry-remote-em] remote is PryRemoteEm 0.7.3 pryem
[pry-remote-em] session terminated
/Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/pry-0.9.11.4/lib/pry/helpers/base_helpers.rb:119:in `stagger_output': uninitialized constant Pry::Pager (NameError)
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/pry-remote-em-0.7.3/lib/pry-remote-em/client.rb:211:in `receive_raw'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/pry-remote-em-0.7.3/lib/pry-remote-em/proto.rb:59:in `receive_json'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/pry-remote-em-0.7.3/lib/pry-remote-em/proto.rb:47:in `receive_data'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/eventmachine-1.0.0/lib/eventmachine.rb:187:in `run_machine'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/eventmachine-1.0.0/lib/eventmachine.rb:187:in `run'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/gems/pry-remote-em-0.7.3/bin/pry-remote-em:64:in `<top (required)>'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/bin/pry-remote-em:23:in `load'
        from /Users/pcmantz/.rvm/gems/ruby-1.9.3-p194@vamp-api/bin/pry-remote-em:23:in `<main>'

All this patch does is load Pry::Pager so that the macro is happy.

gruis added a commit that referenced this pull request Feb 6, 2013
@gruis
Merge pull request #39 from pcmantz/require-pry-pager
d80e4d7 
stagger_output needs Pry::Pager to be loaded in the parent scope
@gruis gruis merged commit d80e4d7 into gruis:master Feb 6, 2013
@adelevie
Copy link

I'm getting this error on v 0.7.3. Any chance you could cut a new gem with this patch?

@gruis
Copy link
Owner

gruis commented Jun 11, 2013

just pushed. give it a try.

@adelevie
Copy link

Thanks!

On Mon, Jun 10, 2013 at 9:59 PM, Caleb Crane notifications@github.comwrote:

just pushed. give it a try.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/39#issuecomment-19236988
.

@adelevie
Copy link

And it works!

I've got this running on an Ubuntu server and can access it via localhost on the same server. Next I'm going to try to get this working remotely using your instructions from twitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmantz @adelevie @gruis